refactor: optimize error message concatenation in default_validator#4685
Merged
appleboy merged 1 commit intoJun 2, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4685 +/- ##
==========================================
- Coverage 99.21% 98.37% -0.84%
==========================================
Files 42 48 +6
Lines 3182 3141 -41
==========================================
- Hits 3157 3090 -67
- Misses 17 42 +25
- Partials 8 9 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
appleboy
approved these changes
Jun 2, 2026
Premiermoney
added a commit
to Premiermoney/gin
that referenced
this pull request
Jun 4, 2026
* refactor: optimize error message concatenation in default_validator (gin-gonic#4685) * feat(context): add Scheme() with proper reverse proxy support (gin-gonic#4655) * feat(context): add Scheme method to determine HTTP scheme from request * test(context): add tests for Scheme method * docs(context): align inline comments in GetPostForm example (gin-gonic#4675) Standardize comment alignment in GetPostForm documentation example to improve readability and maintain consistency with code formatting conventions. * chore(deps): bump golang.org/x/net to v0.55.0 (gin-gonic#4678) Signed-off-by: Tero Saarni <tero.saarni@est.tech> * fix(response): panic on Hijack/CloseNotify when wrapper unsupported (gin-gonic#4645) * response_writer: don't panic on Hijack/CloseNotify when wrapper unsupported Closes gin-gonic#4638. http.TimeoutHandler's writer doesn't implement http.Hijacker/CloseNotifier; mirror Flush's graceful degradation. * response_writer: keep Written() false when Hijack is unsupported Signed-off-by: Sai Asish Y <say.apm35@gmail.com> --------- Signed-off-by: Sai Asish Y <say.apm35@gmail.com> Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com> --------- Signed-off-by: Tero Saarni <tero.saarni@est.tech> Signed-off-by: Sai Asish Y <say.apm35@gmail.com> Co-authored-by: wanghaolong613 <wanghaolong613@163.com> Co-authored-by: Raju Ahmed <73926176+raju-mechatronics@users.noreply.github.com> Co-authored-by: Leehainuo <lihainuo0502@gmail.com> Co-authored-by: Tero Saarni <tero.saarni@est.tech> Co-authored-by: Sai Asish Y <say.apm35@gmail.com> Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: optimize error message concatenation in default_validator
Use separate WriteString calls instead of '+' operator for building
error messages in SliceValidationError to reduce memory allocations.